Draft
Conversation
alinush
commented
Dec 11, 2025
alinush
commented
Dec 11, 2025
alinush
commented
Dec 11, 2025
ec69441 to
66e01f9
Compare
29 tasks
alinush
commented
Dec 11, 2025
alinush
commented
Dec 11, 2025
852a350 to
bcfd2c6
Compare
0xmaayan
reviewed
Dec 11, 2025
e3a7534 to
90b4b90
Compare
gregnazario
reviewed
Dec 13, 2025
| "@aptos-labs/aptos-client": "^2.1.0", | ||
| "@noble/curves": "^1.9.0", | ||
| "@noble/hashes": "^1.5.0", | ||
| "@noble/post-quantum": "^0.5.2", |
Collaborator
There was a problem hiding this comment.
This should be an optional dependency. There have been multiple requests that our SDK is too big by default
Contributor
Author
There was a problem hiding this comment.
How do we do that? Since if the AIP passes, enshrining this PQ scheme on Aptos, then the SDK would need to support it => this dependency needs to be in.
Co-authored-by: Maayan <maayan@aptoslabs.com>
Co-authored-by: Maayan <maayan@aptoslabs.com>
90b4b90 to
6fd871f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on top of aptos-labs/aptos-core#18300 by adding support for creating post-quantum signatures (as per AIP-137).
Specifically, adds support for SLH-DSA-SHA2-128s:
Steps to confirm this works with an Aptos node
First, have Docker launched and
pnpmprerequisites installed:Second, set up a local net:
Third, run the e2e TXN submission test:
Note
I have already ensured tests pass on a local net deployed from this modified
aptos-corebranch: aptos-labs/aptos-core#18300Tasks
noble/post-quantumdependency (somehow; perhaps @gregnazario can advise)pnpm test/pnpm jestto work with @noble-post-quantumaptos-coreaptos-corefromDerivationPathfor the private key using "SLH-DSA-SHA2-128s seed" as theCurveparameter andnset toTest Plan
Checklist
pnpm fmt?CHANGELOG.md?